The background color, foreground color, and border color of the pop-up window are inconsistent and do not match ...
zhouxinghong opened this issue · 2 comments
This extension is very well designed!
The only problem currently is that the background color, foreground color, and border color of the pop-up window are inconsistent and do not match the background color, foreground color, and border color of the theme.
Hope this can be improved in the next version! Thank you very much for a very excellent extension. 👍😜
Obsidian: 1.4.16
Extension latest version
Windows 10 19044
You can adjust them using the Style Settings plugin. The plugin was written by @nothingislost for an older version of Obsidian that did not have the current theme color options, and the CSS hasn't really been reviewed since. The colors work fine with the themes I use so I've never looked closely at it.
Checking over the CSS now, it seems there are some greys and whites that are hardcoded for the title bar background and text on accent; they should be listed in Style Settings as "Inactive unpinned title bar background color", "Inactive pinned title bar background color", "Active title bar foreground color", and "Titlebar active icon color".
Some notes in the CSS indicate that the original author had trouble finding theme variables to use for some of these; I'm not familiar enough with the new theming system to know what to replace them with. If you can find somebody knowledgeable to suggest good variables to use, I'll update the CSS to use them so the colors will change with the theme instead of being hardcoded.
It is best to find experienced friends to improve this issue! 👍😜