Missing `withBindableCallbacks` crashes
Mecharyry opened this issue · 1 comments
Mecharyry commented
Problem
If a client creates an instance of Merlin without specifying withBindableCallbacks when creating Merlin a crash occurs when performing a Merlin.bind. This occurs because we do not check for a null instance when forwarding onBind events. See here for the problematic class.
Potential Solution
Only forward onBind events when the forwarder has an instance of the BindCallbackManager attached.
Impact
No crash in client applications. Merlin should only respond to events that clients are interested in and swallow all others.
Mecharyry commented
This issue has been resolved and was released in version 1.1.4.