novoda/merlin

Custom RequestMaker

jakoss opened this issue · 2 comments

Problem

I would like to create my custom RequestMaker. The health endpoint that i need to use requires authorization and HMAC header. I cannot add those using Merlin's build-in HttpRequestMaker

Potential Solution

I could create PR with RequestMaker injection feature. Custom RequestMaker could be injected using MerlinBuilder.

Are you open for PRs? I see that library is quite stale for a while.

I'd say yes, if a PR was pushed that gave a clear and obvious change that didn't have any breaking changes for backward compatibility it'd be accepted :-) (and if anyone with release rights wants to correct me, please do! I just assume not that many ppl will reply here)

I think i can do that :) Should i merge to develop or release branch?