Slow Method could be improved

Question

Slow Method could be improved

blundell opened this issue 9 years ago · 7 comments

blundell commented 9 years ago

(recommended 0.32ms)

Answer 1 · 2016-01-27T14:05:22.000Z

where does that recommended time come from?

Answer 2 · 2016-01-27T14:26:31.000Z

I have no idea what reference they have for that. Isn't it the time per frame before jank?

Answer 3 · 2016-01-28T10:43:00.000Z

could be the time ignoring GC
¯_(ツ)_/¯

Answer 4 · 2016-02-03T16:32:46.000Z

Using TimingLogger we determined this is the line that causes the slow down for this

String[] sqls = assets.list(migrationsPath); (Migrations:121)

The issue only arises when you have a certain number of migration files (device dependent) 10_ migration files in our case.

Considering alternative solutions, we can't speed up assets.list as it is a framework class.
We could move all assets to res/xml as these would be compiled and the name references would be available instantly, however this is a breaking api change and not being considered right now.
We could also allow the library user to pass the number of the file wanting to be used so that this lookup is not needed. However this might not be possible due to the creation time and also it defeats half the point of having the migration file (vs the normal version number declaration).

So right now this is a WILL NOT FIX.

Answer 5 · 2016-02-03T16:33:29.000Z

[[selfie-0 uploading...]]

Answer 6 · 2016-02-04T08:39:15.000Z

is the beef that this is working on the main thread?

Answer 7 · 2016-02-04T08:58:05.000Z

yeah, don't think it can be backgrounded ... it's instantiating the content provider