noxdafox/pebble

Unhelpful error message `ProcessExpired('Abnormal termination')`

ghilesmeddour opened this issue · 1 comments

ghilesmeddour commented

Hi,

pebble/pebble/concurrent/process.py

Line 157 in 58d9b45

return ProcessExpired('Abnormal termination')

ProcessExpired('Abnormal termination') is not very useful. What do you think about returning the error as is?

noxdafox commented

Hello,

The ProcessExpired error is raised when the process executing the decorated function dies unexpectedly as documented. From the parent process, there is no more information we can provide as the actual reason for the process to die was most likely lost with the process itself.

You can get hints from the exitcode on what might have been the reason for the process to die (external signal, OOM, segfault etc).

Forwarding the OSError/EOFError as you suggest would only make things more confusing as the User would see something like OSError("got end of file during message"). This not only does not provide any better explanation regarding the root cause but misleads the User into thinking there is some messaging issue with their code.