npisanti/ofxPDSP

MidiKeysBuffer keeping highest and lowest note

Closed this issue · 1 comments

potrepka commented

@npisanti

The following code on line 272 of ofx/helper/MidiKeysBuffer.cpp feels arbitrary and is actually problematic for me, since it clashes with how external plugins treat MIDI note stealing.

                for(int i=0; i(notes.size()); ++i){
                        if(notes[i].notehighest){
                                highest = notes[i].note;
                                indexHighest = i;
                        }
                }

Vote to remove? Would like to hear your thoughts. Having it commented out locally works for me, too.

npisanti commented

the highest and lowest notes are the ones that you can ear most in polyphonic composition, so there should be the last notes to be stolen, i made an effort to make it like that. ofxPDSP has some opinion on note stealing and how envelopes should behave and i want to keep it like this.

  • 👍1