Issue with "fi" ligature in HTML2Canvas

Question

Issue with "fi" ligature in HTML2Canvas

Closed this issue 9 years ago · 8 comments

One of our producers noted that fi combo would result in the i being dropped. After some experimentation I discovered that the one-liner font-feature-settings: "liga" 0; in the CSS for the Quotable blockquote element fixed the issue. For consideration, I'll put together a pull request too.

eads commented 9 years ago

Whoa!

👍1

ghing commented 9 years ago

Same.

Answer 1 · 2016-06-20T13:24:07.000Z

@TylerFisher @jjelosua can one of you take a look into this?

Answer 2 · 2016-06-20T14:47:16.000Z

I'll take a look at @davisshaver's PR.

Answer 3 · 2016-06-20T18:02:00.000Z

Hm. I wonder if Gotham just doesn't have that ligature? What fonts are y'all using @davisshaver @ghing?

Answer 4 · 2016-06-20T18:31:51.000Z

@TylerFisher I think I was just using whatever font is the default. I think the only thing I overwrote in the CSS was the background color and logo image.

Answer 5 · 2016-06-20T19:33:58.000Z

Cool, replicated and merged @davisshaver's PR. Works great.

Answer 6 · 2017-01-17T12:43:23.000Z

I solve this problem using a condition to check if the word has "fi" in the html2canvas.js
textList = ((!options.letterRendering && /^(left|right|justify|auto)$/.test(textAlign) && noLetterSpacing(getCSS(el, "letterSpacing"))) || (textNode.nodeValue.indexOf("fi") !== -1) ) ?