possible bad releases?

[dpsutton]

Piggieback seems to have some deps bundled with it that absolutely should not be there:

 clj -Sdeps '{:deps {cider/piggieback {:mvn/version "0.5.1"}}}' -Stree
org.clojure/clojure 1.10.1
  org.clojure/core.specs.alpha 0.2.44
  org.clojure/spec.alpha 0.2.176
cider/piggieback 0.5.1
  org.clojure/clojurescript 1.8.51
    org.clojure/data.json 0.2.6
    org.clojure/google-closure-library 0.0-20151016-61277aea
      org.clojure/google-closure-library-third-party 0.0-20151016-61277aea
    org.mozilla/rhino 1.7R5
    com.google.javascript/closure-compiler v20160315
      com.google.javascript/closure-compiler-externs v20160315
      com.google.guava/guava 19.0
      args4j/args4j 2.0.26
      com.google.protobuf/protobuf-java 2.5.0
      com.google.code.findbugs/jsr305 1.3.9
      com.google.code.gson/gson 2.2.4
    org.clojure/tools.reader 1.0.0-beta1
  nrepl/nrepl 0.6.0
  javax.xml.bind/jaxb-api 2.3.1
    javax.activation/javax.activation-api 1.2.0

compared to

clj -Sdeps '{:deps {cider/piggieback {:mvn/version "0.4.2"}}}' -Stree
org.clojure/clojure 1.10.1
  org.clojure/spec.alpha 0.2.176
  org.clojure/core.specs.alpha 0.2.44
cider/piggieback 0.4.2

diffing the project.clj from master against 0.4.2 we have

diff -U 1 project.clj project.clj.4.2
--- project.clj	2020-11-02 11:17:07.000000000 -0600
+++ project.clj.4.2	2020-11-02 11:17:03.000000000 -0600
@@ -1,2 +1,2 @@
-(defproject cider/piggieback "0.5.1"
+(defproject cider/piggieback "0.4.2"
   :description "Middleware adding support for running ClojureScript REPLs over nREPL."
@@ -11,4 +11,2 @@
   :deploy-repositories [["clojars" {:url "https://clojars.org/repo"
-                                    :username :env/clojars_username
-                                    :password :env/clojars_password
                                     :sign-releases false}]]
@@ -17,3 +15,3 @@

-  :profiles {:provided [:1.8 :nrepl-0.6]
+  :profiles {:provided [:1.8 :nrepl-0.5]

@@ -36,4 +34,5 @@

+             :nrepl-0.4 {:dependencies [[nrepl/nrepl "0.4.5"]]}
+             :nrepl-0.5 {:dependencies [[nrepl/nrepl "0.5.3"]]}
              :nrepl-0.6 {:dependencies [[nrepl/nrepl "0.6.0"]]}
-             :nrepl-0.7 {:dependencies [[nrepl/nrepl "0.7.0"]]}

which shows no real changes.

Its been a bit since i've really looked at lein. I see there's a make release which runs lein with-profile +$(VERSION) release $(BUMP) and version is VERSION ?= 1.10. So I'm confused why its being set with 1.8 rather than 1.10, but also why that version is included at all.

[bbatsov]

I always build it the same way, so I'm puzzled. Might be related to technomancy/leiningen#2687, as I see some composite profiles here.

[jimmyhmiller]

I originally posted about this issue on slack. Because of the clojure 1.8 (and others) inclusion, I had a classpath conflict on a boot project when trying to do cider-jack-in-clojurescript. I followed @dpsutton instructions, did a clone of the repo. Did lein jar && lein install. Now I can run the project fine.

Running

clj -Sdeps '{:deps {cider/piggieback {:local/root "target/piggieback-0.5.1.jar"}}}' -Stree

Also shows me it doesn't have those dependencies in my local jar.

[bbatsov]

Yeah, that was technomancy/leiningen#2687 indeed. I've cut a new release and the deps are looking good now. I'll push a fix for CIDER as well.