nrk/PredisServiceProvider

Tag for stable for Silex 2

Closed this issue ยท 6 comments

Hi,

I was wondering if you are planning on creating a release branch/tag with a stable version for Silex 2?
Master seems stable ATM for usage with Silex 2/Pimple, but I would like to set my projects composer config on release rather than master.

Same here :)

nrk commented

Sorry for being so inactive on this project, I'll try to make up for it soon ๐Ÿ˜„ As for a new branch and release targeting Silex 2... yes it's going to happen, I just have a doubt if the Predis\Silex namespace should remain as is or if we could rename it as Predis\Pimple, this service provider doesn't really depend on Silex anymore after all. Any thoughts on this?

No worries. I just figured the master branch is working fine for me so why not tag it :) I'm fine with changing the namespace to I'm fine withPimple` too, makes sense.

I've no strong opinion on the move to another namespace.
For example the Silex providers have been made independent of the Silex Application and rely on Pimple only, yet they are still in the Silex namespace (for example https://github.com/silexphp/Silex-Providers/blob/master/AssetServiceProvider.php).

nrk commented

Tagged with no changes for the namespace of this provider.

Thank you @nrk !