nx:rspack does not respect the skipTypeChecking options
hanstf opened this issue · 0 comments
hanstf commented
Current Behavior
when I try to pass skipTypeChecking as false or typeCheck as false (even though I have impression of typeCheck as false has different meaning than skipTypeChecking as false ), the type check never been performed.
Expected Behavior
when passing skipTypeChecking as false or typeCheck as false, type check should be performed
GitHub Repo
No response
Steps to Reproduce
- create project with rspack executor
- set the skipTypeChecking as false or typeCheck as true
- run the rspack executor
Nx Report
Node : 18.18.2
OS : darwin-arm64
Native Target : aarch64-macos
npm : 9.8.1
nx : 20.1.4
@nx/js : 20.1.4
@nx/jest : 20.1.4
@nx/eslint : 20.1.4
@nx/workspace : 20.1.4
@nx/devkit : 20.1.4
@nx/eslint-plugin : 20.1.4
@nx/nest : 20.1.4
@nx/node : 20.1.4
@nx/plugin : 20.1.4
@nx/rspack : 20.1.4
@nx/web : 20.1.4
typescript : 5.4.5
---------------------------------------
Local workspace plugins:
generator
Failure Logs
Package Manager Version
No response
Operating System
- macOS
- Linux
- Windows
- Other (Please specify)
Additional Information
not sure if this is because of this but seems https://github.com/nrwl/nx/blob/20.1.4/packages/rspack/src/executors/rspack/rspack.impl.ts#L22 the check is using alias option instead of the actual option, should it be using the same check as the js/swc https://github.com/nrwl/nx/blob/master/packages/js/src/utils/swc/compile-swc.ts#L93 ?