setup_walkoff.py needs to be adjusted to force python3 for all OSes, in particular Ubuntu Linux, which rely heavily on python 2.7+, to facilitate user-friendliness and quick install
astrohart opened this issue · 1 comments
That is really awesome that there is a verison of setup_walkoff.py that works with whatever python executable that runs it.
However, I just want to raise a concern that this still might serve to make WALKOFF un-installable "out of the box" from cloning master, as new users might be wont to do on Ubuntu VMs, for example.
Ubuntu ships with python2 and relies heavily on it. Yet, WALKOFF now relies exclusively on python3. Therefore, I wonder whether a setup_walkoff.py such as was put in the development branch would even work properly on Ubuntu.
My fix guarantees that python3 is used, and this makes WALKOFF installable out of the box for new users.
Right now, as it stands, master is uninstallable on Ubuntu Desktop 18.04 LTS out-of-the-box.
I am also concerned because it does not appear that the github.io website nor any of the tutorials have been updated to conform to WALKOFF being depenedent only on python3 yet.
Therefore, I would push strongly for my pull request to be re-evaluated, and to be added to master as a one-off, so as to better facilitate consumption of this system by new users.
One might say, "well, then don't use Ubuntu." I question whether that would be entirely valid to say, however; since Ubuntu is one of the most popular Linux distros, the thinking is that a wide segment of the potential WALKOFF installation/user base would be on Ubuntu.
I see that setup_walkoff.py now utilizes code that calls whatever python we use to run it with, but I can forsee this can be a problem for a new user who may not know about Ubuntu's preference out-of-the-box for the command python to mean Python2.7+ and I can see that being a scenario where setup_walkoff.py, therefore, would still not be calling the correct Python version.