Don't include color codes in buffer

Question

Don't include color codes in buffer

nriley opened this issue 13 years ago · 6 comments

When I try to copy filenames from the results buffer, the color codes are at least partially still there, so I end up with lines such as:

[0m
�[1;33m

Since (I think) these are all replaced by overlays, could the raw codes be removed?

Answer 1 · 2011-12-16T15:52:45.000Z

You're right. I didn't think of that.

Unfortunately full-ack currently uses font-lock, so removing the codes requires somewhat of a rewrite...

Answer 2 · 2011-12-16T16:09:25.000Z

Yeah, I eventually discovered that. Someday, I guess...

Answer 3 · 2011-12-16T17:43:48.000Z

Well, apparently it wasn't that hard... Please check out https://github.com/nschum/full-ack/tree/experimental

Maybe it didn't break anything. ;)

Answer 4 · 2011-12-16T19:15:00.000Z

Thanks!

The only problem I'm noticing is when I use C-x ` to go through search results, the point in the file (as opposed to the full-ack buffer) is ending up at the end of the previous line rather than at the place where ack matched. For example:

Answer 5 · 2011-12-16T21:41:33.000Z

OK. Please try again. :)

Answer 6 · 2011-12-16T21:46:06.000Z

Much better, thanks!