In the 04-RSVP experiment, I found a problem
Opened this issue · 3 comments
immort-magic commented
when a subscription request of the same priority does not meet the bandwidth allocation, the first subscription request is deleted, it should not be deleted.
In line 417 of rsvp_controller.py, it should be commented, I think it is, you can think about it again.
edgar-costa commented
You mean this line: https://github.com/nsg-ethz/p4-learning/blob/master/exercises/04-RSVP/thrift/solution/rsvp_controller.py#L417
I think it is correct, this line only removes the subscription if its an update
meaning its changing an already existing subscription, it deletes to just update it.
immort-magic commented
immort-magic commented
i think previous reservation should not be deleted