nsg-ethz/p4-learning

In the 04-RSVP experiment, I found a problem

Opened this issue · 3 comments

when a subscription request of the same priority does not meet the bandwidth allocation, the first subscription request is deleted, it should not be deleted.
In line 417 of rsvp_controller.py, it should be commented, I think it is, you can think about it again.

Hi @immort-magic

You mean this line: https://github.com/nsg-ethz/p4-learning/blob/master/exercises/04-RSVP/thrift/solution/rsvp_controller.py#L417

I think it is correct, this line only removes the subscription if its an update meaning its changing an already existing subscription, it deletes to just update it.

I found it, in the case of a failed booking, the previous booking was simply deleted, you can try it.
Snipaste_2024-03-04_16-52-40

i think previous reservation should not be deleted