nsgov/patternlibrary

French footer

Opened this issue · 0 comments

jamie-benoit commented

I was looking for a French Footer code in Github, but there is none. There is only the English version https://github.com/nsgov/patternlibrary/blob/main/navigation/footer.html. This code is different that the code on the website that I found. I have edited both versions with my suggestions.

Suggested updates
change aria-label="Copyright" to aria-label="Droit d'auteur"
change aria-label="Social media links" to aria-label="Les liens de média social"
adding hreflang="en" and hreflang="fr" to links
change the link to Twitter from https://twitter.com/nsgov to https://twitter.com/GouvNE
change https://novascotia.ca/cns/privacy/ to https://beta.novascotia.ca/fr/enonce-de-confidentialite
change https://novascotia.ca/terms/ to https://beta.novascotia.ca/fr/conditions-dutilisation
change https://novascotia.ca/cns/privacy/cookies/ to https://beta.novascotia.ca/fr/droit-dauteur"

Suggested edits to https://github.com/nsgov/patternlibrary/blob/main/navigation/footer.html

   <div class="container">
   <div aria-label="Droit d'auteur" class="copyright">
   		<ul class="remove-underline">
   			<li><a href="https://novascotia.ca/news/rss/" hreflang="en">RSS</a></li>
   			<li><a href="https://www.twitter.com/GouvNE" hreflang="fr">Twitter</a></li>
   			<li><a href="https://www.youtube.com/nsgov" hreflang="en">Youtube</a></li>
   			<li><a href="https://www.facebook.com/nsgov" hreflang="en">Facebook</a></li>
   		</ul>
   		<ul class="remove-underline">
   			<li><a href="https://beta.novascotia.ca/fr/enonce-de-confidentialite" hreflang="fr">Confidentialité</a></li>
   			<li><a href="https://beta.novascotia.ca/fr/conditions-dutilisation" hreflang="fr">Modalités</a></li>
   			<li><a href="https://beta.novascotia.ca/fr/enonce-de-confidentialite" hreflang="fr">Témoins</a></li>
   		</ul>
   		<div><small>Droit d'auteur de la Couronne ©, <span class="word-break-together">Gouvernement de la Nouvelle-Écosse.</span></small></div>
   	</div>
   </div>
</footer>

English code from https://novascotia.ca/snsis/

<footer id="footer" class="footer">
 <div class="container">
   <ul aria-label="Social media links" class="footer-social-links" lang="en">
     <li><a href="https://www.twitter.com/nsgov" hreflang="en">Twitter</a></li>
     <li><a href="https://www.youtube.com/nsgov" hreflang="en">YouTube</a></li>
     <li><a href="https://www.facebook.com/nsgov" hreflang="en">Facebook</a></li>
   </ul>
   <ul class="footer-statement-links">
     <li><a href="https://beta.novascotia.ca/privacy/" hreflang="en">Privacy</a></li>
     <li><a href="https://beta.novascotia.ca/terms/" hreflang="en">Terms</a></li>
   </ul>
   <div aria-label="copyright" class="copyright">
     <small><a href="https://beta.novascotia.ca/copyright/" hreflang="en">Crown copyright © Government of Nova Scotia</a></small>
   </div>
 </div>
</footer>

French code from https://novascotia.ca/snsis/fr with edits

 <div class="container">
   <ul aria-label="Les liens de média social" class="footer-social-links">
     <li><a href="https://www.twitter.com/GouvNE" hreflang="fr" lang="en">Twitter</a></li>
     <li><a href="https://www.youtube.com/nsgov" hreflang="en lang="en"">YouTube</a></li>
     <li><a href="https://www.facebook.com/nsgov" hreflang="en" lang="en">Facebook</a></li>
   </ul>
   <ul class="footer-statement-links">
   	<li><a href="https://beta.novascotia.ca/fr/enonce-de-confidentialite" hreflang="fr">Confidentialité</a></li>
   	<li><a href="https://beta.novascotia.ca/fr/conditions-dutilisation" hreflang="fr">Modalités</a></li>
   </ul>
   <div aria-label="Droit d'auteur" class="copyright">
     <small><a href="https://beta.novascotia.ca/fr/droit-dauteur" hreflang="fr">Droit d'auteur de la Couronne ©, Gouvernement de la Nouvelle-Écosse</a></small>
   </div>
 </div>
</footer>