nsweeting/shopify

OAuth flow in test mock adapter seems incomplete

lewisf opened this issue · 1 comments

def oauth_auth(_) do
end

This function seems to just need to return {:passed, request} in order to continue. Otherwise respond/1 fails, unable to handle nil.

Is there a reason this wasn't completed? Or maybe a future plan? Would love to help out with this if needed.

Yeah sorry for that 💩 We actually realized last week and I made a branch with a quick-fix, just so we could keep working, made a proper pull request now.