ntohq/buefy-next

Taginput tags close button has title "false"

Opened this issue · 0 comments

Overview of the problem

Buefy-next version: 0.1.2
Vuejs version: 4.1.0
OS/Browser: Linux Ubuntu/Firefox

Description

Small issue that I just discovered. In all my Taginputs, I tend do use the aria-close-label attribute, to define how the close icon in the tags will be labeled. I just noticed that it is always set to false the Taginput component... maybe it is related to that Vue 3 behavior of not removing falsy attributes?

Steps to reproduce

Seems to happen with any Taginput so just add one and inspect (example below).

Expected behavior

Seems to me that nothing would appear there by default. I just checked the Taginput documentation but didn't find the aria-close-label. That attribute, however, exists in the Tag component documentation, so I kinda expect it to be passed but will understand if it is ignored.

Actual behavior

image

I tried capturing a screenshot of the false being rendered when hovering the mouse here but I believe it does not appears in screenshot tools... believe me, there is a "false" tooltip due to the title attribute 😅
image