nuke-build/nuke

MinVerDefaultPreReleasePhase is deprecated and will be removed

henry-js opened this issue · 1 comments

Usage Information

8.0.0/8.0.204/8.0/Windows

Description

When using MinVerSettings.SetDefaultPreReleasePhase an error is logged by minver-cli because that command option is now deprecated: https://github.com/adamralph/minver/blob/38681c8f283e109f4b2e0d212d761bd828d16802/minver-cli/Program.cs#L81

Reproduction Steps

Call the minver cli in a Target:

    [MinVer] readonly MinVer MinVer;
    Target PrintVersion => _ => _
        .Executes(() =>
        {
            MinVerTasks.MinVer(_ => _
                .SetMinimumMajorMinor("1.0")
                .SetDefaultPreReleasePhase("preview.0")
            );
            Log.Information(MinVer.Version);
        });

Expected Behavior

Should not get an error message

Actual Behavior

[ERR] PrintVersion: MinVer: warning : MinVerDefaultPreReleasePhase is deprecated and will be removed in the next major version. Use MinVerDefaultPreReleaseIdentifiers instead, with an additional "0" identifier. For example, if you are setting MinVerDefaultPreReleasePhase to "preview", set MinVerDefaultPreReleaseIdentifiers to "preview.0" instead.

Regression?

No response

Known Workarounds

No response

Could you help with a pull-request?

Yes