Remove pinning to release
Closed this issue · 5 comments
There is a release pinning for pymod. This is block the RPM package from installation on Fedora as there is already pymodbus-2.4.0 shipped. The requirements should be softened. This will also cause issues if one is installing it in a venv with other packages that depends on pymodbus.
Thanks
Thanks for the issue @fabaff!
Pymodbus has been pinned because of some instability between versions (changing default endianness, unexpected breaking dependencies, using "async" as package name). If we can get validation that this driver works with pymodbus 2.4.0, then I'm open to bumping the version. However, I doubt I'll be comfortable softening the version requirement entirely.
@JamesJeffryes - Do you mind taking a look?
I've yet to find a way to reliably uncover breaking changes in industrial device communications (especially connection stability) short of manual testing with the hardware. That means that we will likely always be pinned to one release or another. It's a headache having conflicting requirements but elusive bugs are far worse.
It's actually because we install this driver along with other packages like clickplc watlow
and midas that we are pinned to this particular version. I could upload a release candidate to PyPI that's pinned to 2.4.0 if that's a help to you.
The ProductivitySuite simulator is pretty flaky, crashes on various requests, and occasionally gives garbage data. Could be 'good' enough to test in lieu of real hardware, albeit TCP/IP and not serial.
pymodbus-dev/pymodbus@55bf3ad both drops Python 3.5 support and renames some directories.
from pymodbus.client.asynchronous.asyncio import ReconnectingAsyncioModbusTcpClient
try:
from pymodbus.client.asynchronous.async_io import ReconnectingAsyncioModbusTcpClient
except ModuleNotFoundError:
from pymodbus.client.asynchronous.asyncio import ReconnectingAsyncioModbusTcpClient