numba/numba-scipy

Upgrading Scipy dependency to >1.7.3

je-cook opened this issue · 3 comments

je-cook commented

Hi,

Since the most recent numba supports numpy 1.23 is there any chance the scipy dependency can be bumped to a newer version so that numba-scipy can be installed alongside numpy 1.23? Scipy 1.7.3 has a numpy version limit of <1.23.

I've had a bit of a look to see if there seems to be a reason not to. A plain pytest works fine with a few warnings and with pytest -Werror the following three tests fail with the warning numba_scipy/tests/test_special.py:55: DeprecationWarning: non-integer arg n is deprecated, removed in SciPy 1.7.x:

FAILED numba_scipy/tests/test_special.py::test_function[bdtr-specialization125] 
FAILED numba_scipy/tests/test_special.py::test_function[bdtrc-specialization127] 
FAILED numba_scipy/tests/test_special.py::test_function[bdtri-specialization129]

Seemingly as the typing is pulled directly from scipy it is not something numba-scipy can control but even on the most recent scipy (1.9.1) all functions seem to still work with float arguments (although they pump out the same warning). If the functions are used with an int where appropriate both wrapped with numba and without the output seem the same and have no warnings.

Is there anything I am missing to stop bumping the scipy version?

I'm happy to open a PR to bump the version if there isn't. Thanks very much for your work on numba-scipy

esc commented

@je-cook thank you for suggesting this. AFAICT there is no SciPy 1.9 available from anaconda yet:

https://anaconda.org/anaconda/scipy/files

I would like to suggest to wait with the upgrade until it becomes available.

je-cook commented

Thanks for the reply @esc. That makes sense. I assume that you want to stay on the default anaconda branch too?

Otherwise conda-forge already has scipy 1.9.1: https://anaconda.org/conda-forge/scipy

esc commented

Thanks for the reply @esc. That makes sense. I assume that you want to stay on the default anaconda branch too?

Otherwise conda-forge already has scipy 1.9.1: https://anaconda.org/conda-forge/scipy

Ideally, yes, we want to stay on the Anaconda provided packages.

  • 👍1