numpy/numpy-tutorials

Fail CI for warnings

bsipocz opened this issue · 5 comments

bsipocz commented

Ideally we should handle warnings raised during the tutorials, and fail CI with anything that is unexpected.

rossbar commented

Good point! I though we had this covered with the -W option for sphinx-build, but it turns out that doesn't extend to warnings raised during notebook execution.

bsipocz commented

yep, the code content and rendering are handled separately.

You can assign this to me, though I'm not sure when I get to actually do something about it.

rossbar commented

Of course - feel free! I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level.

bsipocz commented

Of course - feel free

I can't do that ;)

I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level.

Ideally, a standard pytest config should do the trick, but f course it doesn't work out of the box :(

rossbar commented

I'm going to go ahead and re-open this - #203 fixed the current batch of warnings, but I agree with the original premise that we need something in CI to fail on runtime warnings.

  • 👍1