Implement proper undo for editor

Question

Implement proper undo for editor

Closed this issue 6 years ago · 4 comments

Current bug is editor undo 'stack' is cleared every time new code is loaded (i.e. user selects a new file). I want editor to preserve the undo stack for each individual file. The solution is to implement 'faux' Tabs (basically hidden file tabs, not really tabs but function as them behind the scenes).

Reference: Monaco Editor Issue 604

Answer 1 · 2018-08-10T00:33:13.000Z

Fixed with 264c444?

Answer 2 · 2018-08-10T01:55:00.000Z

This is actually a different bug/enhancement, I want users to be able to undo even after switching to different files. Right now, once the user selects a different file, the undo stack gets cleared and when the user selects the previous file they had opened, they can't undo anymore.

Answer 3 · 2018-08-10T01:57:38.000Z

Wow, even MS Code cannot do that. I recommend you do not do this. This is not a "bug".

…

On Thu, Aug 9, 2018 at 9:55 PM Sam Lee ***@***.***> wrote: This is actually a different bug/enhancement, I want users to be able to undo even after switching to different files. Right now, once the user selects a different file, the undo stack gets cleared and when the user selects the previous file they had opened, they can't undo anymore. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADP5vamNq_Trc6wxH5CYGtaaHBDwO8Y5ks5uPOf0gaJpZM4VfYv8> .

Answer 4 · 2018-08-10T02:06:03.000Z

Rather than thinking it preserves the undo stack for files, it's more like an alternative to tabs.
Since we don't support tabs, we can preserve the edits for some number of most recently opened files.