nurpax/sqlite-simple

Hackage release does not match repository

fosskers opened this issue · 9 comments

Hi there, the recent Hackage release of version 0.4.17.0 does not seem to match what is in this repo, in particular with respect to the bounds for semigroups as updated in this PR. Something may have gone wrong during the release process.

@sigrlami I wonder if the cabal file’s been edited out of repo in hackage and the changes not brought back to github?

@fosskers @nurpax I'll investigate that

@fosskers local merge went wrong without any indication. I'll have to re-upload the package with updated bounds, so it will be 0.4.18.0. Will check other corrections also.

Is it possible that this also affects other files?

In particular, build of 0.4.17.0 from hackage on ghc 8.8.x seems to be failing because of fail being defined in Monad and not in MonadFail, which is in fact fixed in git for quite a long time now.

The error:

Preprocessing library for sqlite-simple-0.4.17.0..
Building library for sqlite-simple-0.4.17.0..
[ 1 of 12] Compiling Database.SQLite.Simple.Ok ( Database/SQLite/Simple/Ok.hs, dist/build/Database/SQLite/Simple/Ok.o )

Database/SQLite/Simple/Ok.hs:75:5: error:
    ‘fail’ is not a (visible) method of class ‘Monad’
   |
75 |     fail str = Errors [SomeException (ErrorCall str)]
   |     ^^^^

Thanks!

My last PR was supposed to have fixed all that.

It's my fault introducing error on silent merge last week.

  1. Repo reverted to correct version.
  2. version 0.4.17.0 is deprecated
  3. new version 0.4.18.0 uploaded to hackage and tested with lts-15.1, 15.2 with 8.8.x additionally.

@fosskers @exaexa please verify it's working for you. Extra deps required for stack.yaml

extra-deps:
- sqlite-simple-0.4.18.0@sha256:3ceea56375c0a3590c814e411a4eb86943f8d31b93b110ca159c90689b6b39e5,3002
- direct-sqlite-2.3.26@sha256:04e835402f1508abca383182023e4e2b9b86297b8533afbd4e57d1a5652e0c23,3718

Thank you kindly, I'll get this confirmed on Monday!

Yup, looks good! Thank you.

Confirming, 0.4.18.0 works perfectly.

Thanks!