nurupo/vlc-pause-click-plugin

Disable fullscreen toggle on double click does not work

xiaojiuwo1993 opened this issue · 5 comments

Checklist

Environment

  • OS: macOS 10.15.7
  • VLC version: 3.0.11.1
  • VLC bitness: intel64
  • Plugin version: 3.0
  • Plugin bitness: N/A

Describe the bug

When i followed the tutorial of mac os vlc, then I selected disable fullscreen toggle on double click and restart, the double click still activate full screen and single click do pause!

Steps to reproduce

follow the mac os tutorial then select disable fullscreen toggle on double click

Observed behavior

double click full screen still work

Expected behavior

double click enables pause/play function rather than full screen

Additional info

Can you screenshot the settings you have set in Video -> Filters -> Pause click?

截屏2021-01-11 下午8 01 32

Hm, can't reproduce this on Linux. I don't own a macOS machine so I rely on VLC behaving the same across OSes.

I have added some debug printing in the debug branch. Could you use that version of the plugin, run VLC as:

vlc --verbose 2 /path/to/a/video/file 2>&1 | grep ' pause_click '

then double click on the video just once, causing the window to full screen, then close VLC and copy the log you got in the console?

Here is a binary in case you don't want to built it from source: vlc-3.0-macosx.zip

In your screenshot you have assigned full screen toggle to the middle button. Does VLC full screen when you click on the middle mouse button?

In your screenshot you have assigned full screen toggle to the middle button. Does VLC full screen when you click on the middle mouse button?

middle button do not work