nus-mtp/worldscope

Permissions <GET_ACCOUNTS, RECORD_AUDIO> are declared but not used

Closed this issue · 2 comments

Hello, I'm Denis Bogdanas, a research assistant at Oregon Stat University.
I'm working on a tool that automatically introduces runtime permission checks and requests for Android 6 apps. As part of this study I analyzed this app. I was looking at the way permissions are referred in the code.

This app declares permissions <GET_ACCOUNTS, RECORD_AUDIO> in the apk manifest, but doesn't have any code that requires them. It is possible that source code doesn't declare the permissions. I only analyzed apk builds from f-droid. Yet android build mechanism may introduce them when the app uses certain libraries:

https://commonsware.com/blog/2015/06/25/hey-where-did-these-permissions-come-from.html

It won't create any problems on Android 6, but on Android 5- users may wonder why the app needs these permissions and be skeptical of installing the app.

Do you think this is an issue?

best regards,
Denis

ndt93 commented

Hi Denis, Thank you for your feedback.

Our team did this for an undergraduate project in National University of Singapore (NUS) and no long maintain this after the term ended.

Your comment raises a nice issue regardless. The present code doesn't need GET_ACCOUNTS I think but RECORD_AUDIO seems reasonable since we are recording video+audio for live streaming from mobile phones. I didn't work on the Android app for this project however, but just wondering.