nusmodifications/nusmods

Show CPEx tab / landing page before CPEx actually opens

Closed this issue · 1 comments

Right now, we can only show the CPEx Navbar Icon and redirect people to the CPEx landing page if we actually want to open the CPEx itself. They're coupled by this enableCpex feature flag:

export const enableCPEx = true;

It would probably be better if we decouple those 2 actions, and let people see the CPEx tab and navigate to the CPEx page before CPEx actually starts, so that people are reminded that CPEx is going to start when the date approaches. We could totally keep the existing landing page you see when you try to visit /cpex when CPEx is closed, and maybe include the dates of the upcoming CPEx. Anecdotally I know a bunch of people who missed CPEx because of how short it is -- I think people probably check NUSMods more often than remember to read their email and load the infographic with the CPEx dates.

image

We could implement this by splitting enableCPEx into 2 feature flags -- showCPExTab to show the tab in the Navbar and enableCPEx to actually open CPEx and let people login etc.

Fixed in #3669