Exclude Hidden Modules from being exported into iCal
Closed this issue · 4 comments
maverick-g00se commented
Describe the bug
Hello! Modules that are hidden on the timetable appear in the iCal when exported.
To Reproduce
Steps to reproduce the behavior:
- Add a couple of sample modules
- Hide at least one module
- download/export as iCal
- Open the file with TextEdit and you can see an error where hidden modules are exported into the iCal
Expected behavior
Technically what the users export is usually based on what they can see on the timetable, hence, modules that are not visible on the timetable at the time of export should not appear in the exported iCal.
If this does get accepted as a bug, I have already looked through the code and I would like to give it a whirl :)
Screenshots
kokrui commented
I think it's reasonable behaviour for hidden courses to be excluded from ics exports. Go for it! @maverick-g00se
maverick-g00se commented
kokrui commented
Yep @maverick-g00se , I'll do it by the end of this week's office hours on Wednesday :)
kokrui commented
Merged! Thanks for the fix!