Prevent undefined this.$sentry while offline test
c4ss opened this issue · 3 comments
c4ss commented
What problem does this feature solve?
Currently this module will completely avoid creating this.$sentry
when there is no DSN specified or the disabled option is flagged - this causes any this.$sentry.xxx
functions to error and completely prevents offline debugging without sentry reporting.
For local testing no error reporting is necessary as the console log is accessible to us and will end up clogging issues being reporting from real users
What does the proposed changes look like?
serverless-sentry-lib
achieves this by deleting the DSN and installing nonetheless (although this uses the deprecated Raven
package).
DiederikvandenB commented
Hi, thanks for reporting. Would you be willing to open a PR for this?
DiederikvandenB commented
Thanks! I have some other commits I need to merge in too. On my todo for tonight or tomorrow.