nuxt-modules/snipcart

Memory leak

tipmisle opened this issue · 7 comments

tipmisle commented

Hi,
I noticed that in my case there was a memory leak when I used this plugin in my Nuxt.js project.
Every time I updated something and the rebuild on my dev environment triggered it was doubling the memory usage until it finally crashed after 2-3 rebuilds.
Everything worked fine when I removed the module.
Nuxt.js version: 2.14.12
Snipcart module version: 1.1.1

Thanks for looking into the issue.

flozero commented

Thanks for your message. I will look at it. I think the fast solution is going to be to delete the watch I am doing on it. And work on a better implementation.

  • 👍1
flozero commented

I am publishing a new version will be 1.2.1 Can you test and tell me if you still have the leak. I tried on my side I have none

  • 👍1
tipmisle commented

Thanks for the quick response, I haven't had the time to test it out again. I will post here once I do it. Thanks again for the quick intervention, appreciate it.

flozero commented

can you please try verse 1.2.2 please :) ?

sampsonpete commented

Hi @f3ltron, I noticed that when editing snipcart/customize.css or snipcart/customize.js there still seems to be a memory leak. It doesn’t happen when editing other files but only when using these files to customize Snipcart.

flozero commented

Ok thanks to let me know i reopen the issue. I need to find time to understand what happen here.

  • 👍1
flozero commented

I am not able to have a clear understanding on this issue nor if it's nuxt or my plugin related. Closing it for now if someone else have the issue also re open it please