Update tokens structure
bdrtsky opened this issue · 3 comments
bdrtsky commented
Current tokens structure have few limitations. For example links (and all other elements using typography.color
) are not automatically inheriting color
from app. There's few questions I like to discuss
- Simplest thing could be done is moving tokens from
typography.color
tocolor
, so app colors applying without any user action. But there's a chance that user might want to have separate colors for his typography. For example, we has blue as hiscolor.primary
but he wants lightblue palette to be applied on typography. - What about purely typography tokens, like
typography.fontSize
,typography.letterSpacing
,typography.fontWeight
,typography.lead
? Currently they also scoped totypography
. Which means that if user installs Typography, possibly could have 2 separate typography tokens, because he could havefontSize
,letterSpacing
,fontWeight
,lead
already. Does it make sense to enforce Typography tokens if user decide to install package? - I would rename
lead
tolineHeight
I've started PR here, but then those questions appeared - #19