Code: copy button should be at bottom

Question

Code: copy button should be at bottom

atinux opened this issue 2 years ago · 5 comments

atinux commented 2 years ago

See on https://nuxt-com-git-feat-typography-nuxtlabs.vercel.app/docs/getting-started/configuration

Answer 1 · 2022-11-08T11:58:38.000Z

Happy to fix this today @bdrtsky ?

Answer 2 · 2022-11-08T13:23:09.000Z

How do you have it? it's empty here https://github.com/nuxt-themes/typography/blob/main/components/CopyButton.vue

Answer 3 · 2022-11-08T13:24:34.000Z

Why CopyButton even exist in this repo @Tahul

Answer 4 · 2022-11-08T15:10:56.000Z

I think there is two issues here:

nuxt.com has its own CopyButton.vue, at least it seems like so in the screenshot
ProseCode ain't done yet, and I think we should think of the best way to handle that specific component

What I would suggest is:

Removing CopyButton from nuxt.com
Finishing the implementation of CopyButton from this repository
Think of the best way to let users overwrite it

I would suggest it is called ProseCodeCopyButton now, as it might conflict with other components from the user project, CopyButton seem a bit too generic as a name.

Answer 5 · 2022-11-08T15:16:04.000Z

I like ProseCodeCopyButton

Happy to remove it from nuxt.com once we have it.

I believe a ProseCode that has a copy button is great UX by default :)