After updating an Add-on that does not meet the system requirements, the old version of the Add-on is lost
Closed this issue · 4 comments
Steps to reproduce:
- Start NVDA on Windows 10 Version 21H2 and install the following Add-on
https://github.com/kefaslungu/resourceMonitor/releases/download/23.06/resourceMonitor-23.06.nvda-addon - Restart NVDA and update the Add-on through the store
- During installation, it prompts that the system does not meet the requirements.
- Restart NVDA
Actual behavior:
The old version of Add-on is lost, and the resourceMonitor.json file appears in the %appdata%\NVDA\addons folder
Expected behavior:
The old version of Add-on is retained and the resourceMonitor.json file should not be generated
NVDA logs, crash dumps and other attachments:
none
System configuration
NVDA installed/portable/running from source:
installed
NVDA version:
2024.2beta3(2024.2.0.32151)
Windows version:
Windows 10 21H2 (AMD64) build 19044.4412
Name and version of other software in use when reproducing the issue:
none
Other information about your system:
none
Other questions
Does the issue still occur after restarting your computer?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
Not tested
If NVDA add-ons are disabled, is your problem still occurring?
Not tested
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Not tested
Hi,
I think this extends to any add-on that raises exceptions in the end, and Resource Monitor is one of those. If yes, I think we may have a record of this issue somewhere.
Thanks.
Hi,
Also, could you mind testing the issue with latest alpha release to make sure the issue can be reproduced across NVDA releases?
Thanks.
Hi,
Turns out this issue is reproducible in alpha builds as well and occurs whenever add-on install routine raises exceptions (tested with a modified Windows App Essentials bundle with installTasks.onInstall function that does nothing but raises RuntimeError exception). I propose creating a more general issue or changing the scope of this problem to cover other cases.
Thanks.