nvim-lua/plenary.nvim

Automatic tagging based on conventional commits

mrcjkb opened this issue · 6 comments

mrcjkb commented

Hey @Conni2461 😄

A while back, I added the workflow that publishes plenary.nvim to LuaRocks.org whenever a new tag is created.

It's been quite a while since a tag was created, so the luarocks package has become quite outdated.

Would you be open to one of the following 2 approaches to fix this?

  1. Automatic tags/releases based on conventional commit prefixes
    e.g. using a workflow like this one

  2. (if you would not like to maintain SemVer tags) Changing the luarocks release workflow to run periodically (e.g. daily), checking for new commits on the main branch and incrementing the patch version
    e.g. as is done by fzf-lua

Conni2461 commented

I am not sure there is any benefit in automation releases. Id rather should start doing releases again (i kinda forgot, my bad).

As far as i remember is that we dont even have a release plan (or guidelines or something similar like we do in telescope) for this plugin.

We are currently also trying to move away from plenary anyway some of the features we are heaily using are already available upstream.

There is also a telescope issue, were we discussed how to reduce the plenary dependency (i am on mobile so dont know which issue id).

Conni2461 commented

Ill do another release tomorrow morning utc. Thanks for reminding me, i actually just forgot about plenary releases

  • 👍1
mrcjkb commented

Sounds reasonable. Thanks 😃

There is also a telescope issue, were we discussed how to reduce the plenary dependency (i am on mobile so dont know which issue id).

I guess this is it? nvim-telescope/telescope.nvim#2552

Thanks for the info.
I'll see if I can get rid of the plenary dependency in my plugins...

oflisback commented

Thank you for considering another release, even a manual release now and then would help a lot I think.

I'm not too well acquainted with the ecosystem but for instance this is how Astronvim references plenary, i.e. via ^0.1 semver pattern:

https://github.com/AstroNvim/AstroNvim/blob/main/lua/lazy_snapshot.lua#L33

So Astronvim users are on a now pretty old version while plugin developers are perhaps introducing dependencies on later fixes, for example I would like to rely on curl.lua on_error for error handling, but that will not work for anyone currently targeting a release tag.

Conni2461 commented

I'll try to tag more often. Automatically based on conventional commits isn't that useful imo