nvim-telescope/telescope.nvim

Latest commit(s) today broke all my Telescope pickers

GitMurf opened this issue · 12 comments

Description

Reverting back to commit d00d9df works fine. Here is the error I am getting with the newest commits from today:

[telescope] [WARN 22:57:50] C:/Users/.../lazy/telescope.nvim/lua/telescope/pickers.lua:669: Finder failed with msg: ...ckstart-data/lazy/telescope.nvim/lua/telescope/utils.lua:702: bad argument #1 to 'ipairs' (table expected, got nil)

I am on newest nightly build.

Neovim version

NVIM v0.10.0-dev-2961+g4d52b0cf6
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

Operating system and version

Windows 11

Telescope version / branch / rev

latest master

checkhealth telescope

n/a

Steps to reproduce

n/a

Expected behavior

No response

Actual behavior

n/a

Minimal config

n/a

Exact same thing happened to me. Did as you pointed out and reverted to the commit and everything went back to normal.

Running on NVIM v0.9.5 and macOS

Thanks @gsvaliente for confirming it is NOT only a nightly build issue. Looks like both stable and nightly have same problem.

Can someone provide a minimal config to test against? I can't reproduce this.

Are you guys all using a custom path_display function?
I believe this is the cause of the bug.

I'm merged a fix for this custom path_display usage. #3067
If people can confirm that that was the cause, I'll close this issue.

can confirm, I had the issue, and the latest commit fixes the issue

Are you guys all using a custom path_display function?

Yes I am using custom path display. I will test in the morning and let you know. Thanks!

Just to update, my errors while using path_display are now gone with the new commit.

I'm having this exact issue on the latest commit fac83a5 when using path_display()

@mawkler can you create a new issue? I think I'll need more specifics considering others are claiming that the issue is resolved.

I'm going to consider this one as complete.

I tried to create a minimal config to reproduce the error, but instead I get another error:

E5108: Error executing lua: ...im/lazy/telescope.nvim/lua/telescope/actions/history.lua:76: attempt to call field 'path_expand' (a nil value)

Here's my minimal config:

Click to expand
local lazypath = vim.fn.stdpath('data') .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    'git',
    'clone',
    '--filter=blob:none',
    'https://github.com/folke/lazy.nvim.git',
    '--branch=stable', -- latest stable release
    lazypath,
  })
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
  {
    'nvim-telescope/telescope.nvim',
    dependencies = 'nvim-lua/plenary.nvim',
    config = function()
      local function telescope_home()
        require('telescope.builtin').find_files({
          search_dirs = { '$HOME' },
          prompt_title = 'Press Ctrl-C for error',
          path_display = function(_, path)
            return path
          end,
        })
      end

      vim.keymap.set('n', 'H', telescope_home, {})
    end
  }
})

The error appears when I try to close Telescope.

It's a really odd error because the method path_expand is clearly there when I check in lua/telescope/utils.lua:37

I have observed the same error, but only if the currently open file is Cargo.toml. Does this have something to do with automatic project root detection?