nvzqz/FileKit

Support Swift 4

Vitaliyy-jomedia opened this issue · 10 comments

Vitaliyy-jomedia commented

When do you plan to add support for Swift 4

Ponyboy47 commented

Just opened a pull request for Swift4 support: #49

It really wasn't too bad to get everything compiling on swift4

  • 👍1
nvzqz commented

With the official release of Swift 4, this is now top priority. Seeing as #49 has a few unwanted changes, I'll attempt to update the project myself this upcoming weekend.

I'm very sorry for the long delay.

liufsd commented

1

phimage commented

need help @nvzqz ?
I can do it this week end

nvzqz commented

@phimage Yes please, if you wouldn't mind. School work is keeping me busy and this feels more like a chore than anything else 😅.

phimage commented

73b86c7

  • Conversion to swift 4
  • travis file for Continuous integration. You can enable it by logging into https://travis-ci.org
  • Keep the original error cause in FileKitError
    • In a lot of case we want to know why the operation failed
    • Introduce a derived ReasonError in FileKitError in some specific case where this is no Foundation Error
  • fix swiftlint warning

I do not update FileKitInfo, for release.
I update readme and podspec but tag do not exist yet

nvzqz commented

@phimage thank you very much for your work on this. I'll tag and release your changes soon.

nvzqz commented

Released v5.0.0 on CocoaPods

theeternalsw0rd commented

Using v5.0.0 xcode has deprecation warning about ExpressibleByStringInterpolation in Path.swift with swift 4. Seems to indicate removal is imminent. Perhaps a dot release of swift 4 will break it.

phimage commented

@theeternalsw0rd this is an other topic.
This warning has been already there in swift3
I did not find any replacement for this feature. I someone find it, please PR.