nwg-piotr/azote

[bug] Screen height is deprecated

epsilon-0 opened this issue · 9 comments

Describe the bug
when running azote from command line, I get a warning

main.py:746: DeprecationWarning: Gdk.Screen.height is deprecated
  h = screen.height()

To Reproduce
Start azote from command line

Expected behavior
No warning

Desktop (please complete the following information):

  • Linux distribution: Gentoo
  • WM: Wayfire

Azote version (please state it clearly if you use -git version):

  • 1.7.14

LOL, it's not a bug, it's a feature. ;)

Seriously: Azote detects screens in several ways, according to the environment. This warning should be harmless, but now I realize that this part of code does not have to be used on Wayland. I'll try to resolve it sooner or later, but it should not stop Azote from working, does it?

No worries, I'll let this be open as a shameful reminder for the disappointment that you are to your ancestors 😛 /s.
But feel free to close if you like, or close when its resolved, any is fine.

LOL, it's not a bug, it's a feature. ;)

Seriously: Azote detects screens in several ways, according to the environment. This warning should be harmless, but now I realize that this part of code does not have to be used on Wayland. I'll try to resolve it sooner or later, but it should not stop Azote from working, does it?

Kind of does. All images are stretched, no matter if tile/center.

Well, can't confirm...

image

image

I will try to see what is happening. Thanks!

As I felt mentally trapped in between of C++ and python, I decided to have a brake with Imperial Stout, so I won't even touch the code at the moment. Feel free to open an issue if you confirm any scaling problem.

By the way: Azote was designed primarily with multi-headed setups in mind. That's what it looks like on my machine:

image

Resolved in slightly tricky way.

:D
Nice, thanks!