Applying suggestions always inserts a newline too
Closed this issue · 5 comments
At least it does on Windows in a file with LF line endings, I wouldn't be surprised if there's some platform nonsense going on here.
I think this is maybe just nwolverson/purescript-suggest#7 - is this where applying a remove import leaves a blank line instead? Sounds like not the same as nwolverson/vscode-ide-purescript#75 if you have LF.
Hah, no, it's different to either of those actually - the most prominent case is import related, but it's where the imports are updated (redundant imports from the module, not that the import is entirely redundant). It adds a new empty line under the import that is rewritten, rather than at the end of the buffer too.
Can you retest this with latest, there should be some relevant changes
Works a treat now 😍
Great :)