nwutils/nw-builder

PR test coverage requirement

zkrige opened this issue · 7 comments

zkrige commented

Any new PR's should have minimum test coverage requirements of 80% - but only for the changes.

so if theres 20 lines changed, 16 of them should be covered by tests

ayushmanchhabra commented

What's weird is that in both #1035 and #1040, the symlinks test passed in GitHub CI but failed on your local machine (or was it CircleCI?).

zkrige commented

that is weird. it was failing on my local Mac AND on circle build. When I get a chance I'll review those tests to check if they're testing the right thing

  • 👍1
zkrige commented

ah - the decompress.test.js doesnt actually test if symlinks exist after extracting. it just runs runs a decompress and then continues. the macOS one should ALSO check that symlinks exist once decompress has finished

  • 👍1
ayushmanchhabra commented

Any new PR's should have minimum test coverage requirements of 80% - but only for the changes.

https://coveralls.io/ ?

zkrige commented

I think this is more relevant https://github.com/Bachmann1234/diff_cover

  • 👍1