nwutils/nw-builder

Hardcoded path to .exe doesn't work for rcedit

williamwang96 opened this issue · 2 comments

williamwang96 commented

Issue Type

  • Bug Report
  • Feature Request
  • Other

Current/Missing Behaviour

For Windows builds, rcedit isn't doing anything.

Expected/Proposed Behaviour

These two lines are probably better off to use a platform-independent solution. Interestingly the first line still works but not the second.

nw-builder/src/bld/winCfg.js

Line 40 in bf7a53d

await rename(`${outDir}/nw.exe`, `${outDir}/${app.name}.exe`);

and

nw-builder/src/bld/winCfg.js

Line 42 in bf7a53d

await rcedit(`${outDir}/${app.name}.exe`, {

I updated the second line to be this and it worked for me.
image

  • Package version: 4.1.0-beta.3
  • Operating System: Windows 10
  • Node version: v18.14.2
  • NW.js version: v0.72.0
ayushmanchhabra commented

Must have overlooked this. PR would be great!

  • 👍1
williamwang96 commented

Will create a PR today or tomorrow.