nwutils/nw-builder

libffmpeg not being installed into correct folder

zkrige opened this issue · 5 comments

zkrige commented

Issue Type

  • Bug Report
  • Feature Request
  • Other

Current/Missing Behaviour

fetching ffmpeg doesn't seem to install it

Expected/Proposed Behaviour

Fetching ffmpeg installs it in correct folder

Additional Info

I'm seeing the original libffmpeg.dylib in the folders on macOS. It looks like its not being overwritten with the one from the community repo

ayushmanchhabra commented

You're right, I think I broke this in 257350d

zkrige commented

I see this was removed and and is no longer in use

await replaceFfmpeg(options.platform, nwDir, ffmpegFile);

It probably just needs to be put back

ayushmanchhabra commented

AH yes

zkrige commented

Maybe we should keep a ffmpeg folder in the cache dir like you do for nwjs? I think that's how nwjs-builder-phoenix used to do it

zkrige commented

Please reopen - this isn't working. I'll sort a fix for this shortly

  • 👍1