Overview of reviewed/fixed/applied issues/PRs of the abandoned upstream (fixed on nxadm/tail)
nxadm opened this issue · 2 comments
nxadm commented
This repository rebooted the development of tail and we mainly focus on issues and PR on nxadm/tail. However, we try follow and fix "historical" issues and PRs from the dormant repository. Because of the many changes between the frozen state of hpcloud/tail and the new commits on this repo, many issues have already been fixed and need verification or a test-case. This also means that upstream PRs no longer can be applied as is. The changes are cherry-picked and their authors referred in the commit message if possible. Feel free to amend changes or issue a new PR if you're an author.
- hpcloud/tail#11: fixed by merged PRs.
- hpcloud/tail#13: NA (request for enhancement: gz files are not tailed, but archived although it may be considered later is tail is used a replacement for zcat).
- hpcloud/tail#21: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can no longer reproduce, see tdevelioglu/prometheus-nginx-log-exporter#4.
- hpcloud/tail#31: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can no longer reproduce.
- hpcloud/tail#34: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), tests no pass on MS Windows. Windows support warning removed from Readme.
- hpcloud/tail#49: fixed (imported PR hpcloud/tail#149 from @mezzi) .
- hpcloud/tail#54: fixed by upgrade to a recent fsnotify (from v1.2.1 to latest, 1.4.9 at the moment), can not longer reproduce.
- hpcloud/tail#83: the addition of Line.Num with the line number allow to easily implement this on client code by skipping lines < n.
- hpcloud/tail#90: upstream fsnotify bug fsnotify/fsnotify#194, fixed by fsnotify/fsnotify#260 (to be merged), validated in branch https://github.com/nxadm/tail/tree/bug122.
- hpcloud/tail#92: rejected (use case not completely clear, can be merged later).
- hpcloud/tail#93: fixed (PR #7 from @lukedirtwalker).
- hpcloud/tail#94: already merged.
- hpcloud/tail#95:
- hpcloud/tail#96: fixed (moved code to go modules and version tags)
- hpcloud/tail#97: already merged.
- hpcloud/tail#98: already merged.
- hpcloud/tail#104: the Stop() should stop the thread. Using context is a possibility in a future v2.
- hpcloud/tail#107:
- hpcloud/tail#108: rejected (implements a similar functionality as hpcloud#149 + external dependency).
- hpcloud/tail#109: NA (information request about fsnotify)
- hpcloud/tail#114: merged.
- hpcloud/tail#116: NA (already implemented).
- hpcloud/tail#117: while hpcloud/tail only supports Windows through polling, nxadm/tail also support fsnotify (default among all the supported OSes).
- hpcloud/tail#120: merged.
- hpcloud/tail#121: fixed (can not reproduce after changes in this repo).
- hpcloud/tail#122: NA (same bug as hpcloud#90).
- hpcloud/tail#123: rejected: the addition of Line.Num with the line number allow to easily implement this on client code by skipping lines < n.
- hpcloud/tail#125: rejected (PR for vendored library, not for tail).
- hpcloud/tail#126: merged.
- hpcloud/tail#127: NA (request for information: No, if the file is deleted, it will be reopened).
- hpcloud/tail#128: merged.
- hpcloud/tail#129: merged.
- hpcloud/tail#130: merged.
- hpcloud/tail#131: merged.
- hpcloud/tail#132: NA (request available information)
- hpcloud/tail#133: merged.
- hpcloud/tail#134: NA (same bug as hpcloud#90).
- hpcloud/tail#135: rejected (PR results in errors when a file does not yet exist, see jwilder/dockerize#112).
- hpcloud/tail#142: fixed (example compiles now).
- hpcloud/tail#144: NA (request for information: responsibility of logrotation program, e.g. copytruncate in logrotate).
- hpcloud/tail#145: already merged.
- hpcloud/tail#146: fixed (moved code to go modules and version tags).
- hpcloud/tail#149: merged.
- hpcloud/tail#150: NA (question about upstream state).
- hpcloud/tail#151: fixed (nxadm/tail uses go modules and more recent dependencies), tested under qemu (Linux 4da9abb41a67 5.8.0-40-generic #45-Ubuntu SMP Fri Jan 15 11:05:36 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux).
- hpcloud/tail#152: merged
- hpcloud/tail#153: behaviour documented.
- hpcloud/tail#154: NA (request for information: responsibility of logrotation program, e.g. copytruncate in logrotate).
- hpcloud/tail#157: Request for information (influxdata/telegraf#6539).
- hpcloud/tail#158: NA (question about fsnotify).
- hpcloud/tail#159: already implemented, vendor kept for now for older go releases.
- hpcloud/tail#160: fixed (addressed by PR #9).
- hpcloud/tail#161: fixed (addressed by merging PR hpcloud#162 and other changes. Downstream projects like greenplum-db/gpbackup, owncloud/ocis and asim/go-micro build on Solaris, Illunimos and DragonFly).
- hpcloud/tail#162: merged.
- hpcloud/tail#163: already implemented.
- hpcloud/tail#164: NA (the behaviour is normal: if the file is not closed (saved) fsnotify will not pick up the change).
- hpcloud/tail#165: rejected: each Line in the Lines channels has already a Seekinfo and Filenumber.
- hpcloud/tail#166: already implemented.
- hpcloud/tail#167: already implemented.
- hpcloud/tail#168: fixed (nxadm/tail uses go modules).
- hpcloud/tail#169: already implemented.
- hpcloud/tail#171: fixed (nxadm/tail uses go modules).
- hpcloud/tail#173: already implemented.
- hpcloud/tail#174: NA (question about API).
- hpcloud/tail#176: NA (not a bug, question about API: once EOF is reached it needs to be reopened),
- hpcloud/tail#177: NA (llgo was dropped from LLVM).
- hpcloud/tail#178: fixed (nxadm/tail uses go modules).
- hpcloud/tail#179: NA (question about API).
- hpcloud/tail#180: already implemented.
- hpcloud/tail#181: Fixed on nxadm/tail by changes for hpcloud/tail#34.
- hpcloud/tail#182: NA (already fixed).
- hpcloud/tail#183: NA (already fixed).
- hpcloud/tail#184: NA (already fixed).
justinsantoro commented
how about hpcloud/tail#54?
nxadm commented
@justinsantoro Do you have the problem with this fork? nxadm/tail uses the latest fsnotify (1.4.9). If the problem still exists, please open an issue on this repo (I will hide the comments on this overview ticket).