nxext/nx-extensions

Solid: Support nx v20

sudokar opened this issue · 13 comments

sudokar commented

Is your feature request related to a problem? Please describe.

I have set up a new repo using Nx v20 along with @nxext/solid@19.0.2. Upon running nx g @nxext/solid:app my-app getting the below error.

image

Describe the solution you'd like

I think, support for nx 20 is required to get this plugin working with Nx 20

Describe alternatives you've considered

Using Nx 19 until it is supported

pawel-twardziak commented

@sudokar Are you willing to raise a PR for that? I am about to do it as I need it in my project - just let me know if you are going to do do it yourself.

suds-sky commented

@pawel-twardziak , Please feel free to 😄

  • 🚀1
pawel-twardziak commented

Ok @suds-sky , it is coming... 🚀 😆

  • ❤️1
pawel-twardziak commented

@DominikPieper I've just raised a PR with NX 20 migration + aligning solid package. I am proceeding the rest but maybe @sudokar @suds-sky wants us to bake https://www.npmjs.com/package/@nxext/solid ASAP?

pawel-twardziak commented

@suds-sky @sudokar done! 8 hour hackathon 🤣 to get this shit done 👯
@DominikPieper ready to CR 👍

  • 🚀2
sudokar commented

@suds-sky @sudokar done! 8 hour hackathon 🤣 to get this shit done 👯 @DominikPieper ready to CR 👍

Wow! Great work @pawel-twardziak. Thanks. I should have joined your hackathon 😄 I didn't think it would require a PR with 80 files changed ⭐

  • 😄2
pawel-twardziak commented

hehe @sudokar for your request there are only 2 commits with around 10 changed files 🤣 the rest changed files are related to the other packages. The migration is for the entire repo 😃

sudokar commented

Thanks @pawel-twardziak and @edbzn, for quickly getting this in 🚀

  • ❤️1
pawel-twardziak commented

Not at all @sudokar 👍 now test it and tell us what are the next issues 😆

  • 👍1
sudokar commented

Not at all @sudokar 👍 now test it and tell us what are the next issues 😆

Have just tested it @pawel-twardziak and found that it is still giving me the same issue. Can you check your side and see what happens.

Steps to replicate:

bunx create-nx-workspace --pm bun
cd my-app
bun add @nxext/solid -d
nx g @nxext/solid:app solid-app

Deps:

nx: 20.0.0
@nxext/solid: 20.0.0

pawel-twardziak commented

@sudokar sure thing, will check, thanks for reporting :)

pawel-twardziak commented

@sudokar could open a new issue for that? I am investigating

pawel-twardziak commented

Ok, I did it :D #1137 - let's follow up there