nyancodeid/quotes

no like or save for localstorage

Closed this issue · 6 comments

izzudin26 commented

this is why i've do pull request with name Adding Like Quote and save it to localstorage

  • Forgetting Save quote and forget keyword to searching quote
  • Saving quote to storage device but not need to share in social media
  • Simple saving quote without spamming on device storage,
  • simple feature with filtering which Quotes we like or no, we just click toggle button and all quotes are showing
nyancodeid commented

Great idea, thanks you @izzudin26 . I think this feature will be very helpful if we find a quote that we like and don't want to lose or find it again.

Is there a screenshot of this feature that we can see now, I haven't had time to see it myself right now, I'm sorry.

izzudin26 commented
2021-10-14.10-53-22.mp4
  • 🎉1
nyancodeid commented

Look good to me, maybe we can't merge this directly to the main branch because it needs a little adjustment so I will merge this feature in the feat/favorite branch. But in general I really appreciate this feature. Good job @izzudin26

In addition, maybe these are some adjustments that we will make:

  • Provides a favorite button in the Quote Gallery (so the button is not only in QuoteDialog only).
  • Adjusted the onSearchChanged method to make it easier to integrate with this feature.
  • Using useStorage to reactively experience localStorage.
  • Mobile view for toggle button.
  • Adjusted formatting/styling.
ngekoding commented

Sorry brothers, I just thinking about the liked quote will make another quote with bad impression.

So what the problem?

It is because we store any types of quotes, from any author and so on. And when the quote is from the prophet (as example) or any related to Islam (shahabah, sheikh, etc...), and the quote have a less like, it is looks not good, that will pushing down the Islam.

I know this is a local storage, but maybe for the future this will go saved on a cloud, and any other feature will comes, like sorting by the most liked, etc.

nyancodeid commented

Sorry brothers, I just thinking about the liked quote will make another quote with bad impression.

So what the problem?

It is because we store any types of quotes, from any author and so on. And when the quote is from the prophet (as example) or any related to Islam (shahabah, sheikh, etc...), and the quote have a less like, it is looks not good, that will pushing down the Islam.

I know this is a local storage, but maybe for the future this will go saved on a cloud, and any other feature will comes, like sorting by the most liked, etc.

As I already mention above, this feature not same as an Upvote or Counted Like. The purpose of this feature is save our favorite quotes. That's why i'm named this feature as Favorite rather than Like, because this lists of favorite quotes is stored on LocalStorage so we didn't store any kind of data into database or server.

I had the same interpretation as you at first, only because I was carried away by the word Like, so I think about it again and ended up just like, it is favorite feature? and yes i think is favorite. So it seems okay for this feature to be implemented here.

  • 👍1
izzudin26 commented

Sorry brothers, I just thinking about the liked quote will make another quote with bad impression.
So what the problem?
It is because we store any types of quotes, from any author and so on. And when the quote is from the prophet (as example) or any related to Islam (shahabah, sheikh, etc...), and the quote have a less like, it is looks not good, that will pushing down the Islam.
I know this is a local storage, but maybe for the future this will go saved on a cloud, and any other feature will comes, like sorting by the most liked, etc.

As already mention above, this feature not same as an Upvote or Counted Like. The porpose of this feature is save our favorite quotes. That's why i'm named this feature as Favorite rather than Like, because this lists of favorite quotes is stored on LocalStorage so we didn't store any kind of data into database or server.

I had the same interpretation as you at first, only because I was carried away by the word Like, so I think about it again and ended up just like, it is favorite feature? and yes i think is favorite. So it seems okay for this feature to be implemented here.

yep maybe just wrong give name for this feature, thank you for accept my pull request :)

  • 👍1