nyancodeid/quotes

Search by user

azizramdan opened this issue · 1 comments

I'm just wondering why not search both by username or name?

Currently if there is a github account then search by github name, if not then search by username written in the quote

case 'user':
if (!quote.github?.available)
return (quote.username.toLowerCase().includes(search.keyword.toLowerCase()))
return (quote.github?.name.toLowerCase().includes(search.keyword.toLowerCase()))

Yes, i think we can do that when github.available is true. Let me know if you can do it.