NR bug fixes
Closed this issue · 7 comments
A collection of NR bugfixes and improvements.
- NR Chart display (below)
- [NaN is ranked "Better" in NRs]
- Climate Report: Poverty - only showing 2008-2012.
- Footer is the same for each report, instead of unique for each report.
Chart display:
NAN issue:
Also mouseover behavior
Also poverty is weird
Labels are fixed, but we're still displaying single-time trend charts. There's a trend_flag field in the report JSON that flags if there's only one time period. We should incorporate this (though as Aaron pointed out, it's not "wrong", just a little dumb).
Agreed. btw - should we consolidate these 3 NR bugs into a single "NR bugfixes/enhancements" issue?
Yeah, let's do that
It occurred to me that NAN ranked better might not actually be an issue. NAN is there because the number is small so suppressed, which probably IS better. i think better/middle/worse is based on 1/2/3 values in the data file, rather than direct value comparisons, for this very reason.
#476 - report footer data was all the same. merging this in to prod.