nypl-spacetime/maps-by-decade

Missing form label in list filter

Closed this issue · 2 comments

seanredmond commented

There is a missing label/element relationship on the filter by title input:

<fieldset class="GWeic">
    <legend>Filter by title:</legend>
    <div class="hhpmBF">
        <input type="text" name="title" value="" id="filter-title" autocomplete="off" placeholder="e.g. &quot;greenpoint&quot;">
    </div>
</fieldset>

The label just needs a for?

bertspaan commented

There is no label...

seanredmond commented

Right. Since there is only one field it probably shouldn't be a <fieldset>, but just a <label> and <input> (in a <div> or something if you need that to hang CSS on)