nystudio107/craft-scripts

Question: file/dir path of backup_dirs.sh

mimamuh opened this issue · 2 comments

mimamuh commented

Hi,

thank you for this awesome scripts. I tested your backup_dirs.sh and I was wondering, why the BACKUP_FILES_DIR_PATH is not using the same structure like backup_db.sh and backups_assets.sh including the db name in the path with ${LOCAL_DB_NAME}:

backup_dirs.sh:
BACKUP_FILES_DIR_PATH="${LOCAL_BACKUPS_PATH}${FILES_BACKUP_SUBDIR}/"

vs. backup_db.sh and backup_assets.sh
BACKUP_DB_DIR_PATH="${LOCAL_BACKUPS_PATH}${LOCAL_DB_NAME}/${DB_BACKUP_SUBDIR}/"

Is there a reason behind the decision?

khalwat commented

hmmm it probably should be, I think