nyxnor/onionjuggler

[FEATURE REQUEST] verify tor config file from a temp file instead of editing the torrc directly

Closed this issue · 3 comments

nyxnor commented

This will avoid tor failing if the configuration if invalid, I wanted to do this anyway as a sudoedit or doasedit for the TUI, but the priority right now is where it is more used, on the CLI.

-f FILE
Specify a new configuration file to contain further Tor configuration options OR pass - to make Tor read its configuration from standard input. (Default: @CONFDIR@/torrc, or $HOME/.torrc if that file is not found)

--verify-config
Verify the configuration file is valid.

So design is:
Copy torrc to "${TMPDIR:-/tmp}", make the changes there.

"${exec_cmd_alt_user}" cp "${tor_conf}" "${TMPDIR:-/tmp}"

Modify scripts to alter the the torrc on the tmp dir.

Verify it with:

"${exec_cmd_alt_user}" -u "${tor_user}" -f "${TMPDIR:-/tmp}/torrc" --verify-config

If valid, reload, if not, abort with error message.

nyxnor commented

so there was a problem.
If user is set on the config, as it happens on openbsd that there is User _tor on /etc/tor/torrc, you can't call tor with doas -u _tor tor .... it will fail. So I have to call tor as root if user is on the config file, else, call tor as its user.

I think this is a bug, anyway... here are my tests:

On Debian, if I verify the default /etc/tor/torrc which does not contain the User config line, I can run with the debian-tor user, but if I use the /usr/share/tor/tor-service-defaults-torrc (which contains the User debian-tor, then it will fail because tor is already running with that user. -- > Tor is already running as debian-tor. You do not need the "User" option if you are already running as the user you want to be. (If you did not set the User option in your torrc, check whether it was specified on the command line by a startup script.)
The above is classified as an warning message
then
[warn] Failed to parse/validate config: Problem with User value. See logs for details.
[err] Reading config failed--see warnings above.
does it needs to error out even if running with the default user?
commands ran: sudo -u debian-tor tor -f /etc/tor/torrc --verify-config (ok) /// sudo tor -f /etc/tor/torrc --verify-config (fail as expected) /// sudo -u debian-tor tor -f /usr/share/tor/tor-service-defaults-torrc --verify-config (fail but should not?) /// sudo tor -f /usr/share/tor/tor-service-defaults-torrc --verify-config (doesnt fail but maybe should?)
on OpenBSD the torrc contains the User option, so it will fail if running: doas -u _tor tor -f /etc/tor/torrc --verify-config
the same way that parsing the configuration via initializing tor only uses the last one, why not ignore this error as it is running with the correct user anyway and not failt to verify config. If it is an issue, I can open one, but if not, would be very helpful if someone could explain please.
when running with the tor user when the user option if already on the config file: [warn] Error setting groups to gid number: "Operation not permitted".

Ok, I can circumvent that if I force the user with an option instead of doas: doas tor -f file --User _tor. But anyway, the above maybe shouldnt fail?
no... it fails trying to access /root/.tor

nyxnor commented

this was done gracefully, I am satisfied, it would be great to do this for other daemon such as the web servers.