changes_comments should have compound foreign key (file_id, hash)
nanokatze opened this issue · 2 comments
nanokatze commented
There can exist same change hash for two or more different files. Example:
- you open two files with exactly same content
- their base changes are both 0
- erase first 4 bytes in both
- change hash is sha256(base + file_pos + change_type + data)
- get collision
nyxxxie commented
@fst3a is this fixed with sqlalchemy changes in feature/implement_project?