oalders/http-browserdetect

Report SamsungBrowser rather than Chrome

oalders opened this issue · 1 comments

Received via email:

I think "SamsungBrowser" should be considered as a standalone browser. Therefore I would expect the following result:

User Agent:

Mozilla/5.0 (Linux; Android 8.1.0; SAMSUNG SM-G390F Build/M1AJQ) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/9.2 Chrome/67.0.3396.87 Mobile Safari/537.36

browser_string SamsungBrowser
browser_version 9.2

I know that "SamsungBrowser" is based on Chromium and also Microsoft Edge will be released soon as Chromium version. Then you would have to display Chrome instead of Edge according to the previous logic.

This was fixed in #192 and can be closed.