oalders/http-browserdetect

Wrong browser_version and engine_string detections for MS Edge

motxx opened this issue · 3 comments

motxx commented

I think browser_version and engine_string are wrongly detected in Chromium-based MS Edge.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 Edg/80.0.361.111

# output
browser:edge, browser_version:5.0, engine_string:EdgeHTML, engine_version:80.0
  • browser_version should be 80.0.
  • engine_string should be WebKit (not Blink as far as I read the document)

I used the followings as reference:

Yes, that looks to be wrong. Thanks for reporting. I would accept a patch to fix this. :)

motxx commented

Thank you for your reply. I created the pull request here: #180

Closed via #180